-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added a new filter-side-drawer component for filtering reports #390
Conversation
…filter has been commented out
… needs to be aligned correctly including other elements in the filter-side-drawer
…e the basic method calls for updating the filter. it just needs to call the updatefilters method in table component now
…vice.ts table component functionality has barely been changed. only difference is that the api request now accepts string arrays so the parameters for the api call have also been changed.
# Conflicts: # src/app/app.module.ts # src/app/debug/table/table.component.ts
src/app/debug/filter-side-drawer/filter-side-drawer.component.html
Outdated
Show resolved
Hide resolved
…html Co-authored-by: Sergi Philipsen <philipsen.sergi@gmail.com>
src/app/debug/filter-side-drawer/filter-side-drawer.component.ts
Outdated
Show resolved
Hide resolved
src/app/debug/filter-side-drawer/filter-side-drawer.component.ts
Outdated
Show resolved
Hide resolved
Co-authored-by: Sergi Philipsen <philipsen.sergi@gmail.com>
… feat/filter-side-drawer
src/app/debug/filter-side-drawer/filter-side-drawer.component.ts
Outdated
Show resolved
Hide resolved
removed resetFilter from filter-side-drawer.component.ts as the trigger might as well call the resetFitler directly in the filterService. updateFilter parameter type added. Added autocomplete feature for filter options. Fixes a known ladybug-frontend issue Fixed filter side drawer size option. now possible to scroll if screen is too small
…Context a debounceTime was added to not overload the API. added cleardebugStorage() to afterEach() cypress e2e test for the filter table
subscriptions moved to dedicated subscribe and unsubscribe methods. Records have been changed to Maps for consistency. small css changes. Added a type to one of the subscribers where I forgot to add one. made filter-side-drawer.component.ts standalone Changed ngIf to an @if in filter-side-drawer.component.html Replaced the empty mat-option with a clear button that shows next to the metadata input element. updated the cypress e2e test accordingly with the new clear button
Co-authored-by: Matthijs Smets <93487259+MatthijsSmets@users.noreply.github.com>
… feat/filter-side-drawer
… feature/filter-side-drawer
…ere it was missing.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Almost there!
src/app/debug/filter-side-drawer/filter-side-drawer.component.html
Outdated
Show resolved
Hide resolved
src/app/debug/filter-side-drawer/filter-side-drawer.component.html
Outdated
Show resolved
Hide resolved
…html Co-authored-by: Matthijs Smets <93487259+MatthijsSmets@users.noreply.github.com>
…html Co-authored-by: Matthijs Smets <93487259+MatthijsSmets@users.noreply.github.com>
@Matthbo @philipsens Does anything else need to be changed before merge? |
I don't have any additional feedback. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, you could've bundled all the subscriptions on a component to one bug subscription variable that you can easily .unsubscribe()
in ngOnDestroy instead of doing it for each subscription on its own.
But this works as well so there is no need to do it now
Pull Request 231 of the Ladybug project should be accepted before accepting this pull request.
Added a filter side drawer that replaces the old filter feature.
The new filter component now communicates with a filter service to send and receive the filters of the table.
Most of the functionality in the table component remains the same to filter the table. Parts that require the input of the filter however have been changed so that it now communicates with the filter service.
This feature also solves issue 290; When multiple filters are filled only one is used.