Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable libz sys for flate2 #562

Merged
merged 2 commits into from
Sep 2, 2024
Merged

Conversation

wcampbell0x2a
Copy link
Owner

@wcampbell0x2a wcampbell0x2a commented May 27, 2024

  • libz-sys now allows to build from cc instead of cmake. This patch enables this
    for the flate2 crate, which should be the fastest implementation of gzip
  • Update LAST_RELEASE to v0.18.0
  • Use libz-sys instead of gzip-zune-inflate when building release binaries
Old(gzip-zune-inflate):
Benchmark 2: backhand-dist
  Time (mean ± σ):     804.6 ms ±  12.8 ms    [User: 1047.7 ms, System: 267.5 ms]
  Range (min … max):   771.8 ms … 837.3 ms    50 runs

Benchmark 3: backhand-dist-musl
  Time (mean ± σ):      1.399 s ±  0.019 s    [User: 1.903 s, System: 0.330 s]
  Range (min … max):    1.358 s …  1.442 s    50 runs

New(flate::libz-sys):
Benchmark 2: backhand-dist
  Time (mean ± σ):     672.0 ms ±   5.9 ms    [User: 846.2 ms, System: 217.1 ms]
  Range (min … max):   659.2 ms … 693.9 ms    50 runs

Benchmark 3: backhand-dist-musl
  Time (mean ± σ):     786.2 ms ±   5.6 ms    [User: 1006.3 ms, System: 203.1 ms]
  Range (min … max):   776.5 ms … 808.8 ms    50 runs

Closes #556

@github-actions github-actions bot added A-backhand-lib A-CI GitHub Action labels May 27, 2024
Copy link

Benchmark for a78d411

Click to view benchmark
Test Base PR %
only_read/netgear_ax6100v2 2.3±0.00ms 2.3±0.00ms 0.00%
only_read/tplink_ax1800 6.2±0.01ms 6.2±0.02ms 0.00%
unsquashfs/full 10.9±0.17ms 11.0±0.11ms +0.92%
unsquashfs/full-path-filter 7.5±0.05ms 7.8±0.08ms +4.00%
unsquashfs/list 7.9±0.08ms 8.1±0.12ms +2.53%
unsquashfs/list-path-filter 7.0±0.04ms 7.1±0.03ms +1.43%
write_read/netgear_ax6100v2 1270.8±3.87ms 1269.4±2.05ms -0.11%
write_read/tplink_ax1800 7.0±0.01s 7.0±0.02s 0.00%

@wcampbell0x2a wcampbell0x2a force-pushed the enable-libz-sys-for-flate2 branch from 5df3fec to 915739b Compare May 27, 2024 21:50
Copy link

Benchmark for 5689c23

Click to view benchmark
Test Base PR %
only_read/netgear_ax6100v2 2.4±0.00ms 2.3±0.00ms -4.17%
only_read/tplink_ax1800 6.2±0.02ms 6.1±0.01ms -1.61%
unsquashfs/full 11.0±0.21ms 11.5±0.27ms +4.55%
unsquashfs/full-path-filter 7.8±0.17ms 8.0±0.19ms +2.56%
unsquashfs/list 8.2±0.13ms 8.3±0.15ms +1.22%
unsquashfs/list-path-filter 7.4±0.22ms 7.4±0.18ms 0.00%
write_read/netgear_ax6100v2 1293.5±9.14ms 1283.5±5.92ms -0.77%
write_read/tplink_ax1800 7.2±0.09s 7.2±0.05s 0.00%

Copy link

Benchmark for b0c171d

Click to view benchmark
Test Base PR %
only_read/netgear_ax6100v2 2.4±0.00ms 2.4±0.00ms 0.00%
only_read/tplink_ax1800 6.2±0.04ms 6.2±0.01ms 0.00%
unsquashfs/full 11.3±0.29ms 11.1±0.14ms -1.77%
unsquashfs/full-path-filter 7.7±0.14ms 7.8±0.12ms +1.30%
unsquashfs/list 8.0±0.14ms 8.2±0.14ms +2.50%
unsquashfs/list-path-filter 7.2±0.12ms 7.2±0.11ms 0.00%
write_read/netgear_ax6100v2 1269.5±1.87ms 1273.5±3.53ms +0.32%
write_read/tplink_ax1800 7.0±0.02s 7.1±0.02s +1.43%

@wcampbell0x2a wcampbell0x2a force-pushed the enable-libz-sys-for-flate2 branch 3 times, most recently from a25096c to 1f68d0a Compare September 2, 2024 16:07
Copy link

github-actions bot commented Sep 2, 2024

Benchmark for 558c1e0

Click to view benchmark
Test Base PR %
only_read/netgear_ax6100v2 2.3±0.00ms 2.3±0.00ms 0.00%
only_read/tplink_ax1800 6.2±0.00ms 6.2±0.02ms 0.00%
unsquashfs/full 10.9±0.12ms 11.1±0.11ms +1.83%
unsquashfs/full-path-filter 7.6±0.06ms 7.7±0.07ms +1.32%
unsquashfs/list 7.9±0.14ms 8.1±0.11ms +2.53%
unsquashfs/list-path-filter 7.1±0.09ms 7.2±0.24ms +1.41%
write_read/netgear_ax6100v2 1273.6±2.26ms 1286.7±4.58ms +1.03%
write_read/tplink_ax1800 7.1±0.02s 7.1±0.02s 0.00%

* libz-sys now allows to build from cc instead of cmake. This patch enables this
  for the flate2 crate, which should be the fastest implementation of gzip
* Update LAST_RELEASE to v0.18.0
* Use libz-sys instead of gzip-zune-inflate when building release binaries

Old(gzip-zune-inflate):
Benchmark 2: backhand-dist
  Time (mean ± σ):     804.6 ms ±  12.8 ms    [User: 1047.7 ms, System: 267.5 ms]
  Range (min … max):   771.8 ms … 837.3 ms    50 runs

Benchmark 3: backhand-dist-musl
  Time (mean ± σ):      1.399 s ±  0.019 s    [User: 1.903 s, System: 0.330 s]
  Range (min … max):    1.358 s …  1.442 s    50 runs

New(flate::libz-sys):
Benchmark 2: backhand-dist
  Time (mean ± σ):     672.0 ms ±   5.9 ms    [User: 846.2 ms, System: 217.1 ms]
  Range (min … max):   659.2 ms … 693.9 ms    50 runs

Benchmark 3: backhand-dist-musl
  Time (mean ± σ):     786.2 ms ±   5.6 ms    [User: 1006.3 ms, System: 203.1 ms]
  Range (min … max):   776.5 ms … 808.8 ms    50 runs
@wcampbell0x2a wcampbell0x2a force-pushed the enable-libz-sys-for-flate2 branch from 1f68d0a to 4b2ade7 Compare September 2, 2024 23:13
Copy link

github-actions bot commented Sep 2, 2024

Benchmark for 2af76ae

Click to view benchmark
Test Base PR %
only_read/netgear_ax6100v2 2.3±0.00ms 2.3±0.02ms 0.00%
only_read/tplink_ax1800 6.2±0.01ms 6.2±0.01ms 0.00%
unsquashfs/full 11.0±0.20ms 11.1±0.21ms +0.91%
unsquashfs/full-path-filter 7.6±0.07ms 7.7±0.06ms +1.32%
unsquashfs/list 7.9±0.15ms 8.1±0.09ms +2.53%
unsquashfs/list-path-filter 7.0±0.05ms 7.2±0.06ms +2.86%
write_read/netgear_ax6100v2 1275.8±3.83ms 1270.3±3.09ms -0.43%
write_read/tplink_ax1800 7.0±0.01s 7.0±0.03s 0.00%

Copy link

github-actions bot commented Sep 2, 2024

Benchmark for 653dafe

Click to view benchmark
Test Base PR %
only_read/netgear_ax6100v2 2.3±0.01ms 2.3±0.00ms 0.00%
only_read/tplink_ax1800 6.2±0.05ms 6.1±0.01ms -1.61%
unsquashfs/full 10.8±0.10ms 10.9±0.16ms +0.93%
unsquashfs/full-path-filter 7.5±0.24ms 7.7±0.11ms +2.67%
unsquashfs/list 7.8±0.05ms 8.0±0.11ms +2.56%
unsquashfs/list-path-filter 6.9±0.08ms 7.1±0.04ms +2.90%
write_read/netgear_ax6100v2 1270.2±3.82ms 1253.2±5.41ms -1.34%
write_read/tplink_ax1800 7.0±0.05s 7.0±0.05s 0.00%

@wcampbell0x2a wcampbell0x2a merged commit 6d59ee4 into master Sep 2, 2024
38 checks passed
@wcampbell0x2a wcampbell0x2a deleted the enable-libz-sys-for-flate2 branch September 2, 2024 23:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Test out libz-sys
1 participant