direnv--directory: Predicate derived-mode test on base buffer mode #51
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Eg: I have a magit status buffer, which I clone with `clone-indirect-buffer-other-window`, then change its mode to fundamental. The directory returned by `direnv--directory` should not care about the major mode of my indirect buffer. Tested by doing the above.
|
sorry @stribb, i totally forgot about this one. is this still relevant and up-to-date? |
|
Huh, so did I :) I think it still is. I see it is still mergeable. |
|
related: #25 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Eg: I have a magit status buffer, which I clone with
clone-indirect-buffer-other-window, then change its mode tofundamental. The directory returned by
direnv--directoryshould notcare about the major mode of my indirect buffer.
Tested by doing the above.