Fix SCRAM username character escape #196
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
According to [rfc5802](https://datatracker.ietf.org/doc/html/rfc5802), username should escape special characters before sending to the server. > The characters ',' or '=' in usernames are sent as '=2C' and '=3D' respectively. If the server receives a username that contains '=' not followed by either '2C' or '3D', then the server MUST fail the authentication.
debuggings
changed the title
debuggings
changed the title
wbarnha
approved these changes
Aug 14, 2024
There was a problem hiding this comment.
If this is only an issue within the context of RFC 5802, then I think this is a behavior I'm willing to accept. Since this is the only usage of self.user in scram.py, I may be making much ado about nothing with my other opinion that having such an implementation here feels awkward.
|
Thanks for your reply. For me, escaping is a part of message preparation, just like |
|
I agree. LGTM! |
|
Hi @wbarnha, may I ask where can I find the release plan? Thanks in advance. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
According to rfc5802, username should escape special characters before sending to the server.