-
Notifications
You must be signed in to change notification settings - Fork 43
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fake oauth server #996
Merged
Merged
Fake oauth server #996
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oj, nie zauważyłem że lint narzeka. Już poprawiam. |
Formatowanie JS powinno zostać naprawione w #999 Edit: zrobione |
rwakulszowa
force-pushed
the
fake-oauth-server
branch
from
July 14, 2021 09:29
d7c824c
to
c5ec388
Compare
Simple server faking google oauth. Changes in backend-project to be implemented in the next commit.
Added a `SOCIAL_AUTH_USE_FAKE_OAUTH` flag that, if set to true, will configure the backend to use a fake oauth server. Talks to a real google oauth api otherwise.
for more information, see https://pre-commit.ci
rwakulszowa
force-pushed
the
fake-oauth-server
branch
from
July 23, 2021 12:25
c5ec388
to
bb4560d
Compare
@ad-m - jeśli takie podejście jest akceptowalne, to możemy zmerdżować. Zmiana ułatwia lokalne testowanie zmian. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #994
FakeProvider
po stronie backenduUstawiłem wartość na
True
w docker-compose (tj. domyślnie używamy lokalnego oauth), przy założeniu, że docker-compose jest używany tylko i wyłącznie lokalnie przez developerów. Jeśli używamy go gdzieś jeszcze - zmienię wartość i dodam do readme.Implementacja jest trywialnie prosta - póki co działa, ale w przyszłości, tj. po dodaniu kontroli dostępu, będzie wymagała zmian - np. kontroli czy zwrócony użytkownik jest adminem czy zwykłym użytkownikiem.