Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added dark mode for sidebar/mobile menu #17

Merged
merged 3 commits into from
Jan 11, 2024

Conversation

martinovicdev
Copy link
Collaborator

  • added dark mode for app menu
  • organised sidebar into one component (AppNavBar) and used it in Landing page instead of same code
  • changed colour of hamburger menu icon on dark mode

Copy link
Collaborator

@vincanger vincanger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we've got some weird behavior on the landing page
image

check line 51 of app/src/client/App.tsx

@martinovicdev
Copy link
Collaborator Author

I have fixed the weird behavior and also removed lucide-icons depenency and replaced that icon

@vincanger vincanger merged commit 7188677 into wasp-lang:main Jan 11, 2024
vincanger pushed a commit that referenced this pull request Jan 12, 2024
* added dark mode for sidebar

* fixed menu behavior

* removed lucide icons, replaced with react-icons icon
@martinovicdev martinovicdev deleted the sidebar-dark-mode branch February 8, 2024 18:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants