Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix GitHub workflow for running tox #287

Merged
merged 3 commits into from
Dec 19, 2022

Conversation

roaldnefs
Copy link
Member

@roaldnefs roaldnefs commented Dec 18, 2022

Fix the GitHub workflow run for running tox by:

Set platform version to Ubuntu 20.04 for running tox in the GitHub
workflows as there is no Python 3.6 available on latest Ubuntu version,
for more information see:
    actions/setup-python#544 (comment).

Signed-off-by: Roald Nefs <info@roaldnefs.com>
@roaldnefs roaldnefs added the Type: Bug Something isn't working label Dec 18, 2022
@roaldnefs roaldnefs self-assigned this Dec 18, 2022
Update the Flake8 URL in the pre-commit configuration file as the
project has moved from GitLab to GitHub.

Signed-off-by: Roald Nefs <info@roaldnefs.com>
Update Flake8 to version 5.0.4 in the pre-commit configuration file.

Signed-off-by: Roald Nefs <info@roaldnefs.com>
@roaldnefs roaldnefs force-pushed the fix/github-workflow-python branch from 348bdbb to a0199fd Compare December 18, 2022 19:27
@roaldnefs roaldnefs changed the title Set platform version to ubuntu-20.04 in GitHub workflow Fix GitHub workflow for running tox Dec 18, 2022
@roaldnefs roaldnefs requested a review from a team December 18, 2022 19:31
Copy link
Member

@jbouter jbouter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All changes approved, however considering the minor changes I'd like to request you merge this commits into one.

@roaldnefs roaldnefs merged commit 0209346 into warpnet:main Dec 19, 2022
@roaldnefs roaldnefs added this to the Version 0.9.0 release milestone Jan 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Type: Bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants