Allow users to ignore old php version extention warnings with the --since-version argument. #4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Most projects support PHP 5.4 at a minimum these days, therefore its almost useless to pollute the result set with extensions bundled since 5.2 etc. This additional flag `--since-version` llows you to pass a version string which will be compared using the `version_compare` function. If the extension php version is less it will be ommitted from the report.
|
Thanks. |
|
I changed your logic of version comparation. It now has |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Its not important if curl wasnt included in PHP 4.0.2 if the project your working requires PHP 5.6/7 anyway, this just gives users the option to ignore those messages in the report.