Events: Skip asides in "fire an event" phrasing #1269
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This completes the "fire an event" extraction logic to ignore annotations that Bikeshed may now add (without whitespaces) next to event names. Note the update also adds a couple of safeguards to while loops that were not properly constrained, although this has likely not have had any impact on extracted info so far. Fixes #1268
dontcallmedom
approved these changes
Apr 24, 2023
src/browserlib/extract-events.mjs
Outdated
| // (note the need to temporarily add the cloned node to the document | ||
| // so that ranges can be used) | ||
| let apos = 0; | ||
| for (let i = 0; i < a.parentNode.children.length; i++) { |
There was a problem hiding this comment.
this could be
const apos = [...a.parentNode.children].findIndex(a);There was a problem hiding this comment.
Indeed, will make the change. FWIW, rather const apos = [...a.parentNode.children].findIndex(c => c === a);
tidoust
added a commit
that referenced
this pull request
Apr 24, 2023
Breaking changes: - Bump minimal supported version of Node.js from v14 to v18 (#1271) Required by dependency on ReSpec, although note this dependency is only for tests (`devDependencies` in `package.json`). The crawler itself should continue to run under previous versions of Node for now but this may not last! Dependencies bumped: - Bump respec from 32.8.0 to 34.0.1 (#1270). This triggers the need to bump the minimal supported version of Node.js. - Bump puppeteer from 19.9.1 to 19.10.1 (#1267) - Bump rollup from 3.20.4 to 3.20.7 (#1266) - Bump semver from 7.4.0 to 7.5.0 (#1264) Feature patched: - Events: Skip asides in "fire an event" phrasing (#1269)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This completes the "fire an event" extraction logic to ignore annotations that Bikeshed may now add (without whitespaces) next to event names.
Note the update also adds a couple of safeguards to while loops that were not properly constrained, although this has likely not have had any impact on extracted info so far.
Fixes #1268