Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: check required cardinality of meta properties #1205

Merged
merged 1 commit into from
Feb 26, 2021

Conversation

rdeltour
Copy link
Member

The cardinality of refining properties defined with the meta element
is defined in Appendix C "Meta Properties Vocabulary":
https://www.w3.org/publishing/epub32/epub-packages.html#app-meta-property-vocab

Summary:

  • add schematron rules to check that properties defined as
    "zero or one" are not defined more than once
  • add test for all properties
  • rename some existing tests for consistency

Fixes #1121

@rdeltour rdeltour added the status: accepted Ready to be further processed label Feb 26, 2021
@rdeltour rdeltour added this to the v4.2.5 milestone Feb 26, 2021
@rdeltour rdeltour self-assigned this Feb 26, 2021
The cardinality of refining properties defined with the `meta` element
is defined in Appendix C "Meta Properties Vocabulary":
  https://www.w3.org/publishing/epub32/epub-packages.html#app-meta-property-vocab

Summary:
- add schematron rules to check that properties defined as
"zero or one" are not defined more than once
- add test for all properties
- rename some existing tests for consistency

Fixes #1121
@rdeltour rdeltour force-pushed the fix/1121/meta-cardinality branch from e4ac71c to bc37c43 Compare February 26, 2021 13:10
@rdeltour rdeltour merged commit edcd253 into master Feb 26, 2021
@rdeltour rdeltour deleted the fix/1121/meta-cardinality branch February 26, 2021 13:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
status: accepted Ready to be further processed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Meta properties + one or zero cardinality
1 participant