[css-shapes-2] Add a detailed example for shape()
#11548
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bramus
reviewed
Jan 21, 2025
bramus
reviewed
Jan 21, 2025
|
Very clear example. Love how you walk through it from start to finish. Added some minor remarks. Otherwise LGTM. |
|
Great example! |
yisibl
reviewed
Jan 23, 2025
|
|
||
| <div class=example> | ||
| The ''shape()'' function enables shapes that are responsive, rather than scalable. | ||
| While the ''polygon()'' shape is also responsive, it doesn't support curves. |
There was a problem hiding this comment.
Great example!
it doesn't support curves.
polygon adds the round keyword, which I think may not be accurately described here.
https://drafts.csswg.org/css-shapes-1/#funcdef-basic-shape-polygon
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This shows how to use
shape()to build a responsive speech bubbleclip-path, replacing SVG pixel values with percentage/pixel/calc/CSS variables.