Persist version strings in database #804
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stalgiag
approved these changes
Oct 4, 2023
| ORDER BY directory, "updatedAt", id | ||
| `, | ||
| { transaction } | ||
| ); |
There was a problem hiding this comment.
Love the presorting here to make the loop cleaner below.
| @@ -4,6 +4,7 @@ | |||
| { | |||
| "name": "Import tests", | |||
| "program": "${workspaceFolder}/server/scripts/import-tests/index.js", | |||
| // "args": ["-c","5fe7afd82fe51c185b8661276105190a59d47322"], | |||
There was a problem hiding this comment.
Thanks for highlighting this, it does look like commented code I forgot to remove 😜 But actually I left it in intentionally because I think it will be useful.
The launch.json enables us to use the VSCode launcher to debug the script that imports the tests from the ARIA-AT repo. However it wasn't very clear how to import a specific commit, which is something we do when creating test environments. This commented code will be useful to anyone who needs to debug the import of a specific commit.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #763. We recently added "version strings" which are short textual representations of the date a test plan was edited. For example a test plan version updated on March 1 would be represented as "V23.03.01".
However, as of yet we have not accounted for the case that multiple updates occurred to a test plan on the same day, in which case two different versions would have an identical version string.
We decided to add a "1" (or "2" etc.) to the second version string. So the version strings would be "V23.03.01" and "V23.03.01-1".
When @mcking65 proposed the solution, he suggested using a underscore. For whatever reason, I found a hyphen looks noticeably better. It bugs me because I can't really articulate why. It just does. So I went with a hyphen. I'd be willing to go back to an underscore if that's a problem.
This ended up being a pretty invasive change because we previously generated the version strings with a small snippet of code wherever they were needed. Now we will generate the strings when the test plan versions are created and store them in the database.