Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ambiguous but normative requirement about hidden nodes is hidden by default in AccName #211

Open
cookiecrook opened this issue Oct 13, 2023 · 6 comments
Open

Ambiguous but normative requirement about hidden nodes is hidden by default in AccName #211

cookiecrook opened this issue Oct 13, 2023 · 6 comments
Assignees
@jnurthen @rahimabdi

Comments

@cookiecrook
Copy link
Contributor

Follow-on from #209.

If you expand the "Comment" details/summary disclosure in comp_labelledby, there is a hidden (ironic?) RFC-2119 requirement:

The result of LabelledBy Recursion in combination with Hidden Not Referenced means that user agents MUST include all nodes in the subtree as part of the accessible name or accessible description, when the node referenced by aria-labelledby or aria-describedby is hidden.

I would first suggest that it's a bad idea to hide normative requirements by default.

Second, I'm not sure what this normative requirement means. "MUST include all nodes" seems like it's requiring all the "if hidden" considerations in the algorithm to be ignored, and all DOM subtree text must be included in the accessible name. But that can't be right.

I think this requirement might be contradictory to the more recent momentum around hidden:

We probably just didn't notice it because it was hidden... 🤣
@spectranaut
Copy link
Contributor

Maybe add "aria-hidden project"?

@cookiecrook
Copy link
Contributor Author

cookiecrook commented Oct 19, 2023 •
edited

I mispoke on the call. A "hidden" project would include more than just aria-hidden: inert, css visibility, display:none, content-visibility, etc.

@cookiecrook
Copy link
Contributor Author

…but the issues span across various specs: html (main spec), html-aam, css, aria, accname, etc. I'm not sure we can make a project in the aria repo that cross-references non-aria-spec issues.

@jnurthen jnurthen assigned jnurthen and pkra and unassigned pkra Nov 2, 2023
@spectranaut
Copy link
Contributor

Discussed in today's meeting: https://www.w3.org/2023/11/02-aria-minutes.html#t09

Missed some of the discussion in the meeting, but the next steps (as I understand them) are:

  1. Rahim makes a test in WPT to verify whether or not this scenario is supported in the browsers
  2. If it is supported only in one or no browsers, then open a PR to remove this note.

Separately, @jnurthen will open an editorial PR to take notes out of the summary details format.

@cookiecrook
Copy link
Contributor Author

FWIW, I think it's okay to have extended notes and examples in a collapsed details. My concern was the buried normative requirement in a collapsed details.

@jnurthen jnurthen mentioned this issue Nov 3, 2023
Closed
This was referenced Nov 9, 2023
Merged
Closed
@rahimabdi
Copy link

rahimabdi commented Nov 16, 2023 •
edited

@cookiecrook @jnurthen @spectranaut Following up on this:

Rahim makes a test in WPT to verify whether or not this scenario is supported in the browsers

Done, here is the WPT test PR: web-platform-tests/wpt#43043.

If it is supported only in one or no browsers, then open a PR to remove this note.

It looks like the current accName 2B note for labelledby, as written, is broadly implemented across browsers (except for some WebKit visibility:hidden/visibility:collapse bugs):

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jnurthen jnurthen

@rahimabdi rahimabdi

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
5 participants
@cookiecrook @pkra @spectranaut @jnurthen @rahimabdi