fix: implement as_wei_value for all numeric type
#3498
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more. @@ Coverage Diff @@
## master #3498 +/- ##
==========================================
+ Coverage 89.17% 89.21% +0.03%
==========================================
Files 84 84
Lines 10882 10882
Branches 2488 2488
==========================================
+ Hits 9704 9708 +4
+ Misses 767 765 -2
+ Partials 411 409 -2
... and 1 file with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
|
@trocher i merged in master and simplified the code paging @cyberthirst for review |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What I did
Fixed #3281
How I did it
Added the required IR for all signed and unsigned types.
How to verify it
See the tests.
Commit message
fix: implement as_wei_value for all numeric type
Description for the changelog
implement as_wei_value for all numeric type
Cute Animal Picture