Add Surface::from_window[_ref], deprecate vulkano-win
#2204
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I really like this, and I use winit for my project anyway. In fact it makes it easier to use winit. Means I don't have to patch and dependencies! Thanks! |
|
I love the way you think! This completely solves the issue I was having with separating the concern of building the window (something I want the user to do on their own terms) from that of initializing the Vulkan's instance and surface (something I want my framework to handle). Thanks! |
hakolao
pushed a commit
to hakolao/vulkano
that referenced
this pull request
Feb 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This rids us of a dependency on winit, since raw-window-handle is all that's needed, once we murk vulkano-win for good. It's also easier for the user since they don't need to add another crate, and the way a surface is created now is much more natural.
Closes #2088
Changelog: