Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(types): define missing slot types #16621

Merged
merged 6 commits into from
Feb 10, 2023
Merged

fix(types): define missing slot types #16621

merged 6 commits into from
Feb 10, 2023

Conversation

johnleider
Copy link
Member

Motivation and Context

Needed for API generator to properly generate slot information.

@johnleider johnleider added T: enhancement Functionality that enhances existing features framework Issues and Feature Requests that have needs framework-wide. T: api-generator labels Feb 8, 2023
@johnleider johnleider added this to the v3.1.x milestone Feb 8, 2023
@johnleider johnleider self-assigned this Feb 8, 2023
@KaelWD KaelWD changed the title refactor: implement genericComponent into components fix(types): define missing slot types Feb 10, 2023
@KaelWD KaelWD self-assigned this Feb 10, 2023
@KaelWD KaelWD marked this pull request as ready for review February 10, 2023 13:42
@KaelWD KaelWD merged commit df0b2dd into master Feb 10, 2023
@KaelWD KaelWD deleted the refactor/implement-generic-component branch February 10, 2023 13:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@KaelWD KaelWD KaelWD approved these changes

Assignees

@johnleider johnleider

@KaelWD KaelWD

Labels
framework Issues and Feature Requests that have needs framework-wide. T: api-generator T: enhancement Functionality that enhances existing features
Projects
None yet
Milestone
v3.1.x
Development

Successfully merging this pull request may close these issues.
2 participants
@johnleider @KaelWD