Task/3948 #4001
Merged
Task/3948 #4001
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gibkigonzo
approved these changes
Jan 20, 2020
pkarw
approved these changes
Jan 20, 2020
There was a problem hiding this comment.
Just a small question added.
Please add the var/catalog.json with the latest dump made by mage2vs for es5 and es6 please
After this being merged we’ll need @afirlejczyk support porting vuestorefront/mage2vuestorefront#99 to mage1-vsbridge-indexer and mage2-vsbridge-indexer
|
One note, vsf-api doesn't return 'options' if it is empty. _id: "4928"
_index: "vue_storefront_magento_1579875515"
_score: 0
attributes_metadata: [{
attribute_code: "cost"
attribute_id: 79
default_frontend_label: "Cost"
entity_type_id: 4
frontend_input: "price"
id: 79
is_comparable: false
is_user_defined: true
is_visible: true
is_visible_on_front: false
}]data in ES. I didn't update vsf-api for some time, so it might be an error only on my side. |
|
@andrzejewsky aren't we merging this in? :) |
|
@pkarw today :) |
This was referenced May 28, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #3948
related: vuestorefront/mage2vuestorefront#99