Skip to content
This repository has been archived by the owner on Mar 8, 2023. It is now read-only.

Update to storefront-query-builder version 1.0.0 #51

Merged
merged 2 commits into from
Apr 9, 2020

Conversation

cewald
Copy link
Contributor

@cewald cewald commented Apr 9, 2020

Related Issues

Update to storefront-query-builder version 1.0.0

This is connected to the update of storefront-query-builder to support new features as extendable filters and more customizable sorting.

Read more about here: vuestorefront/storefront-query-builder#6


  • Update the Unit-Tests to accept the SearchQuery object
  • Update to storefront-query-builder version 1.0.0
  • Update Docs – add a recipe on how to add a custom filters

Short Description and Why It's Useful

This is useful to allow a more flexible way to add or rewrite custom filters without need to fork and edit the storefront-query-builder repository. There is also a more complex sorting added.

IMPORTANT NOTICE - Remember to update CHANGELOG.md with a description of your change

Contribution and currently important rules acceptance

cewald added 2 commits April 9, 2020 04:51
…o import custom filters automatically

* Also add a sample custom filter in `example-custom-filter` module
* Update `bodybuilder` package to be able to use the `clone` method
Copy link
Contributor

@pkarw pkarw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks Christian, you're awesome

@pkarw pkarw merged commit d9b7084 into develop Apr 9, 2020
@cewald
Copy link
Contributor Author

cewald commented Apr 9, 2020

@pkarw You're welcome :) I like to mention, that it shouldn't work yet until the storefront-query-builder package is published under the new version number. Then again we need to update the yarn.lock.

@ResuBaka
Copy link
Collaborator

ResuBaka commented Apr 9, 2020

And there were still things open like updating the packages/default-catalog/package.json with the new version of storefront-query-builder and not only in the root of the repo. ;)

@cewald
Copy link
Contributor Author

cewald commented Apr 9, 2020

@ResuBaka @pkarw I will do both when the package is published and open another PR #52

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants