This repository has been archived by the owner on Mar 8, 2023. It is now read-only.
Feature/fix packages to work from npm #47
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Here we had the problem that the dist folder did not work for some imports.
That is done so we have every part of the project in packages.
That is done so he does not lint node_modules folder in packages/*
ResuBaka
force-pushed
the
feature/fix-packages-to-work-from-npm
branch
2 times, most recently
from
e08b639 to
8cbb97d
Compare
To fix it I used the workaround to install the package in the root workspace.
ResuBaka
force-pushed
the
feature/fix-packages-to-work-from-npm
branch
from
8cbb97d to
3f3ca40
Compare
pkarw
approved these changes
Mar 2, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related issues
closes #26
Short description and why it's useful
Moved all not yet moved core logic into packages and fixed them so that they work for a registry.
I have locally tested it with https://verdaccio.org/.
IMPORTANT NOTICE - Remember to update
CHANGELOG.mdwith a description of your changeContribution and currently important rules acceptance