Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

The path of the RouteConfig is the same as the alias content, which will cause an infinite loop. #2461

Closed
chenfengjw163 opened this issue Nov 1, 2018 · 3 comments · Fixed by mariazevedo88/hash-generator-js#5, noprotocol/Bubblicious#3, tghelere/valorize-vidas#4, tghelere/DeliVuery#18 or tghelere/dailymages#2
Closed

The path of the RouteConfig is the same as the alias content, which will cause an infinite loop. #2461

chenfengjw163 opened this issue Nov 1, 2018 · 3 comments · Fixed by mariazevedo88/hash-generator-js#5, noprotocol/Bubblicious#3, tghelere/valorize-vidas#4, tghelere/DeliVuery#18 or tghelere/dailymages#2
Labels
feature request has PR

Comments

@chenfengjw163
Copy link
Contributor

Version

3.0.1

Reproduction link

https://codepen.io/chenfeng163/pen/qJzxGW

Steps to reproduce

The path of the RouteConfig is the same as the alias content

What is expected?

no error

What is actually happening?

infinite loop

The route of alias overrides the route of the path, causing the path and matchAs to be the same. When the url is parsed, an infinite loop occurs.
@chenfengjw163
Copy link
Contributor Author

chenfengjw163 commented Nov 1, 2018 •
edited
Loading

PR #2462
before:

if (route.alias !== undefined) {
  const aliases = Array.isArray(route.alias)
    ? route.alias
    : [route.alias]

  aliases.forEach(alias => {
    const aliasRoute = {
      path: alias,
      children: route.children
    }
    addRouteRecord(
      pathList,
      pathMap,
      nameMap,
      aliasRoute,
      parent,
      record.path || '/' // matchAs
    )
  })
}

if (!pathMap[record.path]) {
  pathList.push(record.path)
  pathMap[record.path] = record
}

after:

if (!pathMap[record.path]) {
  pathList.push(record.path)
  pathMap[record.path] = record
}

if (route.alias !== undefined) {
  const aliases = Array.isArray(route.alias)
    ? route.alias
    : [route.alias]

  aliases.forEach(alias => {
    const aliasRoute = {
      path: alias,
      children: route.children
    }
    addRouteRecord(
      pathList,
      pathMap,
      nameMap,
      aliasRoute,
      parent,
      record.path || '/' // matchAs
    )
  })
}

@chenfengjw163 chenfengjw163 mentioned this issue Nov 1, 2018
Closed
@posva
Copy link
Member

posva commented Nov 7, 2018

I think a warning makes more sense here as I don't see a reason to have a path with the same value as an alias

@chenfengjw163
Copy link
Contributor Author

chenfengjw163 commented Nov 8, 2018 •
edited
Loading

Yes, but the problem now is that if path and alias are the same, an error will be reported. In #2462 , I have added warning.

if (route.alias === path) {
  warn(
    false,
    `Path with the same value as an alias: ` +
    `{ path: "${path}" }`
  )
}

@posva posva added the has PR label Mar 26, 2019
@posva posva closed this as completed in 04a02c0 Jul 9, 2019
This was referenced Aug 29, 2019
Open
Open
Closed
Open
@tt9133github tt9133github mentioned this issue Sep 18, 2019
Open
This was referenced Sep 22, 2019
Merged
Open
Open
This was referenced Sep 30, 2019
Merged
Open
This was referenced Oct 26, 2019
Open
Open
Open
@snyk-bot snyk-bot mentioned this issue Dec 5, 2019
Open
This was referenced Jan 20, 2020
Merged
Merged
Merged
Merged
@snyk-bot snyk-bot mentioned this issue Jan 27, 2020
Closed
This was referenced Feb 5, 2020
Merged
Open
@snyk-bot snyk-bot mentioned this issue Feb 6, 2020
Merged
@tt9133github tt9133github mentioned this issue Feb 14, 2020
Open
@snyk-bot snyk-bot mentioned this issue Feb 25, 2020
Closed
This was referenced Mar 4, 2020
Open
Open
This was referenced Mar 24, 2020
Merged
Closed
@snyk-bot snyk-bot mentioned this issue Apr 3, 2020
Merged
This was referenced Apr 15, 2020
Open
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
feature request has PR
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[Snyk] Upgrade vue-router from 3.0.2 to 3.1.3 mariazevedo88/hash-generator-js
[Snyk] Upgrade vue-router from 3.0.7 to 3.1.3 noprotocol/Bubblicious
[Snyk] Upgrade vue-router from 3.0.2 to 3.1.3 tghelere/valorize-vidas
[Snyk] Upgrade vue-router from 3.0.1 to 3.1.3 tghelere/DeliVuery
[Snyk] Upgrade vue-router from 3.0.1 to 3.1.3 tghelere/dailymages
[Snyk] Upgrade vue-router from 3.0.1 to 3.1.3 tghelere/vuestore
[Snyk] Upgrade vue-router from 3.0.2 to 3.1.3 estafette/estafette-ci-web
[Snyk] Upgrade vue-router from 3.0.2 to 3.1.4 santosomar/linux_kernel_cves
[Snyk] Upgrade vue-router from 3.0.2 to 3.1.6 OpenTMI/opentmi-default-gui
[Snyk] Upgrade vue-router from 3.0.1 to 3.1.6 LuisAlejandro/luisalejandro.github.io-legacy
2 participants
@posva @chenfengjw163