Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: add XMLSerializer to the global scope #7101

Merged
merged 1 commit into from
Apr 13, 2022

Conversation

maerteijn
Copy link
Contributor

@maerteijn maerteijn commented Apr 8, 2022

In @vue/test-utils 2.0.0rc18, The usage of XMLSerializer was introduced: https://github.com/vuejs/test-utils/blob/d86cbc333de7b2ec1208f5d3c65e0879671dd01e/src/utils/stringifyNode.ts#L4

XMLSerializer needs to be available as a global so cli-plugin-unit-mocha will stay compatible with newer versions of @vue/test-utils.

See also: vuejs/test-utils#1253

What kind of change does this PR introduce? (check at least one)

  • Bugfix
  • Feature
  • Code style update
  • Refactor
  • Docs
  • Underlying tools
  • Other, please describe:

Does this PR introduce a breaking change? (check one)

  • Yes
  • No

Other information:

In @vue/test-utils 2.0.0rc18, The usage of XMLSerializer was introduced: https://github.com/vuejs/test-utils/blob/d86cbc333de7b2ec1208f5d3c65e0879671dd01e/src/utils/stringifyNode.ts#L4

XMLSerializer needs to be available as a global so cli-plugin-unit-mocha will stay compatible with newer versions of @vue/test-utils.
@maerteijn maerteijn force-pushed the fix-cli-plugin-mocha-test-utils branch from 0ebf00d to 535fff6 Compare April 10, 2022 14:54
Copy link
Member

@haoqunjiang haoqunjiang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants