feat: upgrade to eslint 6 #4933
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
FIXME: Pending vuejs/eslint-plugin-vue#985 Need to remove the `resolutions` field in package.json before merging
haoqunjiang
changed the title
haoqunjiang
commented
Dec 5, 2019
| if (config !== 'prettier') { | ||
| // for any config other than `prettier`, | ||
| // typescript ruleset should be appended to the end of the `extends` array | ||
| eslintConfig.extends.push('@vue/typescript/recommended') |
There was a problem hiding this comment.
Not sure whether we should use @vue/typescript/recommended or @vue/typescript here.
pksunkara
reviewed
Dec 12, 2019
|
I gave it a basic look. Looks good. |
|
😅Finally, all the tests are passed! |
pksunkara
approved these changes
Jan 13, 2020
mactanxin
pushed a commit
to mactanxin/vue-cli
that referenced
this pull request
Feb 11, 2020
* feat: scaffold projects with eslint 6 * style: eslint fix * refactor: do not use hard-coded ecmaVersion, use babel-eslint for now * fix: upgrade to @vue/eslint-config-standard * style: continue fix lint errors * chore: upgrade to eslint-plugin-vue@^6.1.2 * refactor: use `ecmaVersion: 2020` for dynamic import syntax support * test: fix baseESLintConfig * chore: also update yarn.lock to fix CI caches * chore: update lockfile again, fix babel regressions * test: nightwatch tests should fail if lint errors occur * chore: update the lockfile (again), fixing a bug in airbnb config
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce? (check at least one)
Does this PR introduce a breaking change? (check one)
Other information: