Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: respect existing package.json #4827

Merged
merged 1 commit into from
Jan 9, 2020
Merged

feat: respect existing package.json #4827

merged 1 commit into from
Jan 9, 2020

Conversation

zyy7259
Copy link
Contributor

@zyy7259 zyy7259 commented Nov 11, 2019

What kind of change does this PR introduce? (check at least one)

  • Bugfix
  • Feature
  • Code style update
  • Refactor
  • Docs
  • Underlying tools
  • Other, please describe:

Does this PR introduce a breaking change? (check one)

  • Yes
  • No

Other information:

This pull request will close #4544

@zyy7259 zyy7259 force-pushed the respect-existing-package.json branch from 9fe2f01 to 6fb189a Compare November 14, 2019 01:43
@zyy7259 zyy7259 force-pushed the respect-existing-package.json branch 2 times, most recently from 9969dcc to 401c9f0 Compare November 30, 2019 15:39
@zyy7259 zyy7259 force-pushed the respect-existing-package.json branch 2 times, most recently from 6b6f6c3 to 57e753e Compare December 9, 2019 02:27
pksunkara
pksunkara suggested changes Dec 12, 2019
View reviewed changes
Copy link
Contributor

@pksunkara pksunkara left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Commented above.

@zyy7259 zyy7259 mentioned this pull request Dec 13, 2019
Merged
9 tasks
@zyy7259 zyy7259 force-pushed the respect-existing-package.json branch 5 times, most recently from 14ea723 to d8e51c5 Compare December 19, 2019 12:03
@zyy7259
Copy link
Contributor Author

zyy7259 commented Dec 31, 2019

@pksunkara hi, I have modified the code as you requested. Should I rebase the code every time when dev has newer commits?

@pksunkara
Copy link
Contributor

Yes, please rebase since we need to re trigger CI

@zyy7259 zyy7259 force-pushed the respect-existing-package.json branch from d8e51c5 to 3971dd5 Compare December 31, 2019 09:01
@zyy7259 zyy7259 force-pushed the respect-existing-package.json branch 2 times, most recently from 93c6c02 to c47afb0 Compare January 6, 2020 03:06
@zyy7259 zyy7259 force-pushed the respect-existing-package.json branch from c47afb0 to ddf478f Compare January 6, 2020 11:54
@haoqunjiang haoqunjiang merged commit eaa2b73 into vuejs:dev Jan 9, 2020
mactanxin pushed a commit to mactanxin/vue-cli that referenced this pull request Feb 11, 2020
@zyy7259 @mactanxin
feat: respect existing package.json (vuejs#4827)
aea43f5
This was referenced Mar 1, 2020
Open
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pksunkara pksunkara pksunkara requested changes

@haoqunjiang haoqunjiang haoqunjiang approved these changes

Assignees
No one assigned
Labels
PR: New Feature
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

"vue create ." overrides existing package.json
3 participants
@zyy7259 @pksunkara @haoqunjiang