Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add missing cli-ui dependencies #4818

Merged
merged 1 commit into from
Nov 9, 2019
Merged

Add missing cli-ui dependencies #4818

merged 1 commit into from
Nov 9, 2019

Conversation

JanCVanB
Copy link
Contributor

@JanCVanB JanCVanB commented Nov 8, 2019

Add missing cli-ui/ dependencies that overlap with the root/package.json. Although cli-ui/ does work if yarn install has been run at the root directory, cli-ui/package.json is an incomplete specification.

What kind of change does this PR introduce? (check at least one)

  • Bugfix
  • Feature
  • Code style update
  • Refactor
  • Docs
  • Underlying tools
  • Other, please describe:

Does this PR introduce a breaking change? (check one)

  • Yes
  • No

Other information:

Add missing `cli-ui/` dependencies that overlap with the root`/package.json`. Although `cli-ui/` does work if `yarn install` has been run at the root directory, `cli-ui/package.json` is an incomplete specification.
@haoqunjiang haoqunjiang merged commit c8392f1 into vuejs:dev Nov 9, 2019
@vue-bot
Copy link

vue-bot commented Nov 9, 2019

Hey @JanCVanB, thank you for your time and effort spent on this PR, contributions like yours help make Vue better for everyone. Cheers! 💚

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants