fix: fix build error when path contains space (close #4667) #4809
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes issue #4667 by implementing the proposal #4667 (comment) Also gets rid of a node module by using simpler code for removing eventual GET parameters
haoqunjiang
requested changes
Nov 8, 2019
Co-Authored-By: Haoqun Jiang <haoqunjiang@gmail.com>
haoqunjiang
approved these changes
Nov 8, 2019
|
Hey @RSeidelsohn, thank you for your time and effort spent on this PR, contributions like yours help make Vue better for everyone. Cheers! 💚 |
haoqunjiang
changed the title
haoqunjiang
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes issue #4667 by implementing the proposal #4667 (comment) (I opened that issue and checked if this change really fixes the issue I had - it does)
Also gets rid of a node module by using simpler code for removing eventual GET parameters
What kind of change does this PR introduce? (check at least one)
Does this PR introduce a breaking change? (check one)
Other information: