refactor: use babel overrides to transpile babel runtime helpers #4777
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As recommended in babel/babel#9903. Get rid of the module-resolver plugin, may fix vuejs#3928. Seems to have fixed vuejs#4742 as well.
|
Should have also fixed #2837 |
|
I was migrating to Vue CLI 4 manually and I think this option is not documented here: https://github.com/vuejs/vue-cli/tree/v4.2.3/packages/@vue/babel-preset-app Am I looking at the right place or is it documented somewhere else? |
|
I think there are no new options introduced in this PR. |
Beeeh, wrong PR. I was supposed to comment here: #4797 Gonna comment there 😅 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As recommended in babel/babel#9903.
Get rid of the module-resolver plugin, may fix #3928.
Seems to have fixed #4742 as well.
There may be a small breaking change: as we now use
excludes&includes, babel requiresfilenameoption to be present (introduced in https://github.com/babel/babel/pull/10181/files). So users who callbabel.transformSyncdirectly may encounter an error.However, as we explicitly stated that this preset is only used for Vue CLI internally, I don't expect too many such use cases there. And the error messages are clear enough.
Considering the benefits that this PR brings, I think it's an acceptable tradeoff.
What kind of change does this PR introduce? (check at least one)
Does this PR introduce a breaking change? (check one)
Other information: