use gitlab CI env variable for project name #4716
Conversation
| @@ -145,7 +145,7 @@ Typically, your static website will be hosted on https://yourUserName.gitlab.io/ | |||
|
|
|||
| module.exports = { | |||
| publicPath: process.env.NODE_ENV === 'production' | |||
| ? '/yourProjectName/' | |||
| ? '/' + process.env.CI_PROJECT_NAME + '/' | |||
There was a problem hiding this comment.
Thank you for working on this!
While I agree with the changing hardcoded value to predefined GitLab CI variable, this also requires removing a comment above the export:
// make sure you update `yourProjectName` with the name of your GitLab project
Also, it would be nice to explain than the project name is a predefined variable in GitLab CI.
There was a problem hiding this comment.
ok, you're right. thanks for taking the time to review this, I've added some explanations and a link to gitlab docs
There was a problem hiding this comment.
By the way, I would advice on using gzip compression on gitlab pages.
It's just one line to add in the .gitlab-ci.yml file, see https://docs.gitlab.com/ee/user/project/pages/introduction.html#serving-compressed-assets
Do you think I could do this in this PR or open a new one?
There was a problem hiding this comment.
Oh, I would agree on using gzip! Let's add it to this PR
|
Hi, I've added gzip support in |
|
Hey @gregoiredx, thank you for your time and effort spent on this PR, contributions like yours help make Vue better for everyone. Cheers! 💚 |
What kind of change does this PR introduce? (check at least one)
Does this PR introduce a breaking change? (check one)
Other information: