fix: fix "lint on commit" projects generation error #4697
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix the "ENOENT: no such file or directory … debugnode_module/sms/index.js" error. The problem are caused by 2 issues: 1. The `lint-staged` packages introduced an old version of debug, causing node_module deduping, thus changing the node_module layout 2. The dependencies required in the cached `lint` module is no longer at its originial position, thus the "ENOENT" error. This change still does not fix the PNPM 4 issue, considering its smaller user base, we'll fix it later.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix the "ENOENT: no such file or directory … debugnode_module/sms/index.js" error.
The problem are caused by 2 issues:
lint-stagedpackages introduced an old version ofdebug,causing node_module deduping, thus changing the node_module layout
lintmodule is no longer atits originial position, thus the "ENOENT" error.
This change still does not fix the PNPM 4 issue, considering its smaller
user base, we'll fix it later.
What kind of change does this PR introduce? (check at least one)
Does this PR introduce a breaking change? (check one)
Other information: