Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore!: add @vue/cli in --version output, to avoid confusion #4681

Merged
merged 2 commits into from
Oct 16, 2019

Conversation

haoqunjiang
Copy link
Member

Sorry for the last-minute breaking change. But I do think it is important to make the branding clearer.
Including the name in the output is also a common practice in command-line tools,
such as bash, brew, etc. And this change only requires minimal effort for other tools to get the version number from the new output format.

Closes #4514

What kind of change does this PR introduce? (check at least one)

  • Bugfix
  • Feature
  • Code style update
  • Refactor
  • Docs
  • Underlying tools
  • Other, please describe:

Does this PR introduce a breaking change? (check one)

  • Yes
  • No

Other information:

@haoqunjiang haoqunjiang changed the title feat!: add Vue CLI in --version output, to avoid confusion chore!: add Vue CLI in --version output, to avoid confusion Oct 15, 2019
@DRoet
Copy link
Contributor

DRoet commented Oct 15, 2019

Wouldn't @vue/cli be the correct branding?

@haoqunjiang
Copy link
Member Author

Yeah you are right 😂
Changed!

@haoqunjiang haoqunjiang changed the title chore!: add Vue CLI in --version output, to avoid confusion chore!: add @vue/cli in --version output, to avoid confusion Oct 15, 2019
@haoqunjiang haoqunjiang merged commit 3677493 into vuejs:dev Oct 16, 2019
@haoqunjiang haoqunjiang deleted the feat-version-number branch October 16, 2019 03:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Make vue --version print both the CLI version and the current version of Vue in use in the current directory
2 participants