Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore!: upgrade terser-webpack-plugin to 2.x #4676

Merged
merged 1 commit into from
Oct 11, 2019

Conversation

haoqunjiang
Copy link
Member

BREAKING CHANGE:
The only real breaking change is webpack-contrib/terser-webpack-plugin#129,
which is not likely to affect normal users.

The rest is default option values changes, which are already covered in
the default provided terserOptions of Vue CLI.

Note that here we choose to disable extractComments by default, as I
don't see enough data showing such license comments taking too much
space. The extra LICENSE file may also be confusing to some users.

What kind of change does this PR introduce? (check at least one)

  • Bugfix
  • Feature
  • Code style update
  • Refactor
  • Docs
  • Underlying tools
  • Other, please describe:

Does this PR introduce a breaking change? (check one)

  • Yes
  • No

Other information:

BREAKING CHANGE:
The only real breaking change is webpack-contrib/terser-webpack-plugin#129,
which is not likely to affect normal users.

The rest are default option values changes, which are already covered in
the default provided `terserOptions` of Vue CLI.

Note that here we choose to disable `extractComments` by default, as I
don't see enough data showing such license comments taking too much
space. The extra LICENSE file may also be confusing to some users.
@haoqunjiang haoqunjiang merged commit 08d7761 into vuejs:dev Oct 11, 2019
@haoqunjiang haoqunjiang deleted the feat-upgrade-terser-plugin branch October 11, 2019 06:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant