refactor!: [wip] make workbox-webpack-plugin a peer dependency #4565
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Considering workbox team is preparing a v5 release. It's likely that in the early-to-middle stage of Vue CLI v4 lifecycle that a major version bump of workbox may happen. By making it a peer dep we could have more flexibility on version strategies.
haoqunjiang
changed the title
|
Closing this because separating such an essential dependency out could be a much larger maintenance burden to us. |
This was referenced Sep 16, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update: I'm very hesitant about this refactor. Will give it another look next week.
TODOs:
vue upgradeto automate the migrationimplement aAdding apostinstallscript for prerelease users who don't usevue upgradeto upgrade this plugin.postinstallscript does not make sense as we've got migrators already. I think adding a strong and explicit is enough.Considering workbox team is preparing a v5 release.
It's likely that in the early-to-middle stage of Vue CLI v4 lifecycle that a major version bump of workbox may happen.
By making it a peer dep we could have more flexibility on version strategies.
We should do the similar to the unit-jest plugin.
IMO these are our last two remaining issues before an official v4 release.
What kind of change does this PR introduce? (check at least one)
Does this PR introduce a breaking change? (check one)
Other information: