Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: migration guide from v3 to v4 #4552

Merged
merged 29 commits into from
Oct 15, 2019
Merged

Conversation

haoqunjiang
Copy link
Member

@haoqunjiang haoqunjiang commented Sep 8, 2019

The preview link: https://deploy-preview-4552--vue-cli.netlify.com/migrating-from-v3/

What kind of change does this PR introduce? (check at least one)

  • Bugfix
  • Feature
  • Code style update
  • Refactor
  • Docs
  • Underlying tools
  • Other, please describe:

Does this PR introduce a breaking change? (check one)

  • Yes
  • No

Other information:

@haoqunjiang haoqunjiang changed the title docs: [wip] migration guide from v3 to v4 docs: migration guide from v3 to v4 Oct 11, 2019
@haoqunjiang
Copy link
Member Author

haoqunjiang commented Oct 11, 2019

I think I've got every breaking change covered in this guide, finally…
Would like to release the stable version once this documentation gets finalized and merged.

@pksunkara
Copy link
Contributor

I guess, this document is both for vue-cli based projects and plugins? Do we want to separate the sections for each?

@LinusBorg
Copy link
Member

Will have a look in a couple of hours

Copy link
Member

@NataliaTepluhina NataliaTepluhina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@sodatea thank you for your work on the migration guide! 🙇‍♀ Added just a few small fixes/nitpicks

docs/migrating-from-v3/README.md Outdated Show resolved Hide resolved
docs/migrating-from-v3/README.md Outdated Show resolved Hide resolved
docs/migrating-from-v3/README.md Outdated Show resolved Hide resolved
docs/migrating-from-v3/README.md Outdated Show resolved Hide resolved
haoqunjiang and others added 4 commits October 12, 2019 12:09
Co-Authored-By: Natalia Tepluhina <NataliaTepluhina@users.noreply.github.com>
Co-Authored-By: Natalia Tepluhina <NataliaTepluhina@users.noreply.github.com>
Co-Authored-By: Natalia Tepluhina <NataliaTepluhina@users.noreply.github.com>
Co-Authored-By: Natalia Tepluhina <NataliaTepluhina@users.noreply.github.com>
@haoqunjiang
Copy link
Member Author

@pksunkara But I don't know how to separate them. There is no clear line between what breaking changes users need to know and what changes are for plugin authors only. Other non-breaking changes may be more appropriate for release notes.

@haoqunjiang
Copy link
Member Author

@NataliaTepluhina Fixed :)

@NataliaTepluhina
Copy link
Member

@sodatea thank you! Approved 👍

@haoqunjiang haoqunjiang merged commit 469d3d8 into vuejs:next Oct 15, 2019
@haoqunjiang haoqunjiang deleted the migration-guide branch October 15, 2019 12:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants