feat: Check for nightwatch.conf.js config
#4445
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Nightwatch checks for `nightwatch.conf.js` instead of the existing `nightwatch.config.js` user options file, this adds a branch to check for the file suggested by upstream as well.
|
mic tap |
haoqunjiang
approved these changes
Sep 3, 2019
|
Hey @LukeeeeBennett, thank you for your time and effort spent on this PR, contributions like yours help make Vue better for everyone. Cheers! 💚 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce? (check at least one)
Does this PR introduce a breaking change? (check one)
Other information:
Nightwatch checks for
nightwatch.conf.jsinsteadof the existing
nightwatch.config.jsuser optionsfile, this adds a branch to check for the file
suggested by upstream as well.
Please see https://nightwatchjs.org/gettingstarted#configuration
There are currently no tests for this behaviour. Feel free to point me in the right direction.