Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: add cwd option when calling globby #4442

Merged
merged 1 commit into from
Aug 21, 2019

Conversation

zrh122
Copy link
Contributor

@zrh122 zrh122 commented Aug 15, 2019

split parent path from patterns and add cwd option, make globby working as expected when project path contains parentheses.
close #4417 .

What kind of change does this PR introduce? (check at least one)

  • Bugfix
  • Feature
  • Code style update
  • Refactor
  • Docs
  • Underlying tools
  • Other, please describe:

Does this PR introduce a breaking change? (check one)

  • Yes
  • No

Other information:

@zrh122 zrh122 force-pushed the fix-calling-globby branch from 58c973f to 0556a1f Compare August 15, 2019 15:32
make globby working as expected when project path contains parentheses
@haoqunjiang haoqunjiang merged commit 51cd831 into vuejs:dev Aug 21, 2019
@vue-bot
Copy link

vue-bot commented Aug 21, 2019

Hey @zrh122, thank you for your time and effort spent on this PR, contributions like yours help make Vue better for everyone. Cheers! 💚

haoqunjiang pushed a commit that referenced this pull request Aug 21, 2019
Make globby working as expected when project path contains parentheses.

Close #4417.

(cherry picked from commit 51cd831)
@zrh122 zrh122 deleted the fix-calling-globby branch August 22, 2019 16:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

vue-cli-service lint bamboozled by paths with parentheses
3 participants