Add --inline-vue flag for build command to avoid externalization of Vue in lib & wc mode
#4261
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
romansp
force-pushed
the
lib-keep-vue-instance
branch
from
af4fc7b to
4c7a989
Compare
romansp
changed the title
keepVueInstance config option to avoid externalization of Vue in Lib modekeepVueInstance config option to avoid externalization of Vue in Lib mode
romansp
force-pushed
the
lib-keep-vue-instance
branch
2 times, most recently
from
bcdd2fe to
d890b22
Compare
romansp
changed the title
keepVueInstance config option to avoid externalization of Vue in Lib mode--inline-vue flag for build command to avoid externalization of Vue in Lib mode
…ernalization of Vue when build target is Lib.Resolves vuejs#4055.
romansp
force-pushed
the
lib-keep-vue-instance
branch
from
d890b22 to
39ce5ec
Compare
haoqunjiang
reviewed
Aug 18, 2019
packages/@vue/cli-service/lib/commands/build/resolveWcConfig.js
Outdated
Show resolved
Hide resolved
haoqunjiang
reviewed
Aug 18, 2019
packages/@vue/cli-service/lib/commands/build/resolveLibConfig.js
Outdated
Show resolved
Hide resolved
haoqunjiang
approved these changes
Aug 18, 2019
|
Pushed code style fixes and also improved consistency for related docs. |
haoqunjiang
changed the title
--inline-vue flag for build command to avoid externalization of Vue in Lib mode--inline-vue flag for build command to avoid externalization of Vue in lib & wc mode
|
Hey @romansp, thank you for your time and effort spent on this PR, contributions like yours help make Vue better for everyone. Cheers! 💚 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR resolves an issue when build is targeting Lib, but for whatever reason Vue instance should be preserved in final bundle.
I followed @seteam1 original suggestion. And also added test case and updated docs. With recommendations by @sodatea.
Option is only used for
--target lib, but might be useful for--target wcas well. Let me know and I update this PR.Would like to hear some feedback is if this change might be accepted to upstream.
Resolves #4055