fix: indexPath should also affect non-production builds (#2327) #4057
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shadow-light
force-pushed
the
patch-for-2327
branch
from
1a76155 to
2f9c83c
Compare
haoqunjiang
approved these changes
Jul 14, 2019
|
Hey @shadow-light, thank you for your time and effort spent on this PR, contributions like yours help make Vue better for everyone. Cheers! 💚 |
haoqunjiang
pushed a commit
that referenced
this pull request
Jul 18, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch fixes two related problems:
indexPathis not respected for non-production builds Documentation: need to explain how used vue.config.js in different build modes #2327build --destis applied after generating webpack config despite a number of elements in that config already setting values based onoutputDirI attempted to make it possible for
--destto override even user webpack config but it was far too complicated, not just in regard toindexPathbut also other parts that rely on it. It might still be desirable if someone wants to have a go. This patch at least improves things in the mean time, as users are already instructed in the docs to setoutputDirin config rather than overriding webpack settings themselves.