If no offline specified. We should remove the tmp dir if it is existed. #390
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
znck
reviewed
Mar 9, 2017
bin/vue-init
Outdated
| console.log(`> Use cached template at ${chalk.yellow(tildify(tmp))}`) | ||
| template = tmp | ||
| } else { | ||
| rm(tmp) |
There was a problem hiding this comment.
IMO it should overwrite existing file after successful download.
There was a problem hiding this comment.
Yes, that's best. Needs another dir to cache the downloads. Otherwise the git will throw an error.
There was a problem hiding this comment.
Native /tmp (😝 And whatever alternative for windows) directory can be used for that.
hoopyfroody
pushed a commit
to hoopyfroody/vue-cli
that referenced
this pull request
Apr 18, 2017
|
Thanks for the PR and sorry for letting it sit for so long. As of now, we are no longer adding new features of vue-cli 2.x, so I am closing this PR. Again, thanks for the contribution. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.