fix(cli-service): Fix copy plugin's ignore pattern (fix #3119) #3130
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
when nested in a subfolder in /public close #3119
haoqunjiang
requested changes
Dec 28, 2018
| @@ -140,7 +140,7 @@ module.exports = (api, options) => { | |||
| const multiPageConfig = options.pages | |||
| const htmlPath = api.resolve('public/index.html') | |||
| const defaultHtmlPath = path.resolve(__dirname, 'index-default.html') | |||
| const publicCopyIgnore = ['index.html', '.DS_Store'] | |||
| const publicCopyIgnore = ['/index.html', '.DS_Store'] | |||
There was a problem hiding this comment.
Actually we can just delete the '/index.html' pattern…
It doesn't match any files as I tested out. But it doesn't break anything because that html-webpack-plugin's output overwrites copy-webpack-plugin's anyway…
There was a problem hiding this comment.
Oh, thought copy would run after the html plugin
haoqunjiang
approved these changes
Jan 7, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
don't skip files named
index.html/publicwhen nested in a subfolder. We only need to ignore the index.html directly under/public/index.html, which is used by html-webpack-plugin as a template.close #3119