feat(cli): allow local .json files for presets (#1068) #1201
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yyx990803
requested changes
May 2, 2018
packages/@vue/cli/lib/Creator.js
Outdated
| @@ -238,6 +239,8 @@ module.exports = class Creator { | |||
| error(`Failed fetching remote preset ${chalk.cyan(name)}:`) | |||
| throw e | |||
| } | |||
| } else if (name.endsWith('.json')) { | |||
| preset = await readLocalPreset(this.context, name) | |||
There was a problem hiding this comment.
Can directly use fs-extra here so it's just JSON.parse(await fs.readFile()) here, I don't think it's necessary to split into a separate file.
There was a problem hiding this comment.
It could even just be preset = await fs.readJson(path.join(this.context, name))
There was a problem hiding this comment.
sounds good. I just followed the pattern for reading remote presets, even though it felt like overkill at the time. Will update PR
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I wasn't sure how to write a test for this (didn't see any for testing the remote preset fetching either), so I didn't write one...