feat(plugin-api): allow non-semver versioned dependencies (#1177) #1184
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
npm supports multiple "version" strings when declaring deps in your `package.json`. This PR is an attempt to support some of these other formats in a plugin specification, while retaining the smart version merging. If a semver range can be extracted, it will be used for version conflict resolution. If not, a warning will be displayed to the developer
yyx990803
reviewed
Apr 27, 2018
| @@ -45,6 +52,8 @@ module.exports = function resolveDeps (generatorId, to, from, sources) { | |||
|
|
|||
| const leadRE = /^(~|\^|>=?)/ | |||
| const rangeToVersion = r => r.replace(leadRE, '').replace(/x/g, '0') | |||
| const extractSemver = r => r.replace(/^.+#semver:/, '') | |||
There was a problem hiding this comment.
shouldn't semver: be optional here?
There was a problem hiding this comment.
according to the npm docs (which do not seem to be 100% accurate), if it is just #... and not #semver:... then it is referring to a commit hash, not a semver
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
npm supports multiple "version" strings when declaring deps in your
package.json. This PR is an attempt to support some of these otherformats in a plugin specification, while retaining the smart version
merging. If a semver range can be extracted, it will be used for
version conflict resolution. If not, a warning will be displayed to
the developer