Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Generated index.html should contain a <noscript> tag #854

Closed
nanomad opened this issue Feb 18, 2018 · 1 comment
Closed

Generated index.html should contain a <noscript> tag #854

nanomad opened this issue Feb 18, 2018 · 1 comment

Comments

@nanomad
Copy link
Contributor

nanomad commented Feb 18, 2018 •
edited
Loading

What problem does this feature solve?

By default a project generated by vue-cli doesn't pass the no-js Lighthouse inspection:

https://developers.google.com/web/tools/lighthouse/audits/no-js

What does the proposed API look like?

vue-cli should add something like the following in index.html inside the body tag to notify users that Javascript is mandatory:

<noscript>
    <strong>We're sorry but {{APP_NAME}} doesn't work properly without JavaScript enabled. Please enable it to continue.</strong>
</noscript>
@nanomad nanomad mentioned this issue Feb 18, 2018
Merged
yyx990803 pushed a commit that referenced this issue Feb 21, 2018
@nanomad @yyx990803
feat: add default <noscript> content (#856)
a489803 
Add some default content that can be seen by browsers where JavaScript
is disabled. See:
https://developers.google.com/web/tools/lighthouse/audits/no-js

Closes #854
@mrksbnch
Copy link

Is there any way to remove this element? E.g. in most cases the app would still work without JS if you are using SSR?

blue-santa pushed a commit to blue-santa/kmd-dev-tools that referenced this issue Dec 12, 2018
Running into Vue issue 854, vuejs/vue-cli#854
21dabc9
@posrix posrix mentioned this issue May 14, 2022
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@nanomad @mrksbnch