Add missing "EOT" (upper case) font extension. #830
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Can't you change the extension to lowercase? I think that's the more common practice... If for some reason you have to use an uppercase extension, the proper fix would be making the regex case-insensitive. |
|
Sure, that's possible. I just didn't realise that it's common practice with EOT font files, and I didn't find any advice with google about that. Also, my previous webpack config specifically mentioned both eot and EOT. |
I already renamed the files, but for completeness here is the change.
|
I'm fine if you close this PR. But if you decide to merge it, it may save someone an hour or two of searching for why one of their fonts just doesn't load and breaks compilation when they move to vue-cli 3. |
|
Thank you. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I have EOT (upper cased) fonts in my project, which currently cause the compilation process to fail with vue-cli 3 alpha 11. This PR fixes the problem.