Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

vue-cli-service lint bamboozled by paths with parentheses #4417

Closed
npfoss opened this issue Aug 9, 2019 · 0 comments · Fixed by #4442
Closed

vue-cli-service lint bamboozled by paths with parentheses #4417

npfoss opened this issue Aug 9, 2019 · 0 comments · Fixed by #4442

Comments

@npfoss
Copy link

npfoss commented Aug 9, 2019

Version

3.10.0

Reproduction link

https://github.com/npfoss/vue-lint-bug

Environment info

  System:                                                                           
    OS: Linux 5.0 Ubuntu 19.04 (Disco Dingo)                                        
    CPU: (4) x64 Intel(R) Core(TM) i7-6560U CPU @ 2.20GHz                           
  Binaries:                                                                         
    Node: Not Found                                                                 
    Yarn: Not Found                                                                 
    npm: Not Found                                                                  
  Browsers:                                                                         
    Chrome: Not Found                                                               
    Firefox: 68.0.1
  npmPackages:
    @vue/babel-helper-vue-jsx-merge-props:  1.0.0
    @vue/babel-plugin-transform-vue-jsx:  1.0.0
    @vue/babel-preset-app:  3.10.0
    @vue/babel-preset-jsx:  1.1.0
    @vue/babel-sugar-functional-vue:  1.0.0
    @vue/babel-sugar-inject-h:  1.0.0
    @vue/babel-sugar-v-model:  1.0.0
    @vue/babel-sugar-v-on:  1.1.0
    @vue/cli-overlay:  3.10.0
    @vue/cli-plugin-babel: ^3.10.0 => 3.10.0                                       
    @vue/cli-plugin-eslint: ^3.10.0 => 3.10.0                                      
    @vue/cli-service: ^3.10.0 => 3.10.0
    @vue/cli-shared-utils:  3.10.0
    @vue/component-compiler-utils:  2.6.0 (3.0.0)                                  
    @vue/eslint-config-airbnb: ^4.0.0 => 4.0.1                                     
    @vue/preload-webpack-plugin:  1.1.1
    @vue/web-component-wrapper:  1.2.0
    eslint-plugin-vue: ^5.0.0 => 5.2.3 (4.7.1)                                     
    vue: ^2.6.10 => 2.6.10
    vue-cli-plugin-vuetify: ^0.6.3 => 0.6.3                                        
    vue-eslint-parser:  5.0.0 (2.0.3)
    vue-hot-reload-api:  2.3.3
    vue-loader:  15.7.1
    vue-style-loader:  4.1.2
    vue-template-compiler: ^2.6.10 => 2.6.10                                       
    vue-template-es2015-compiler:  1.9.1
    vuetify: ^2.0.0 => 2.0.5
    vuetify-loader: ^1.2.2 => 1.3.0
    vuex: ^3.0.1 => 3.1.1
  npmGlobalPackages:
    @vue/cli: Not Found

Steps to reproduce

mkdir "bug"
cd bug
git clone git@github.com:npfoss/vue-lint-bug.git demo
cd demo
yarn install
yarn run lint # finds the issue (mixed tabs/spaces). good!

cd ../..

mkdir "bu(g)"
cd "bu(g)"
git clone git@github.com:npfoss/vue-lint-bug.git demo
cd demo
yarn install
yarn run lint # says everything is fine. bad!

What is expected?

linting should be indifferent to the path to the project

What is actually happening?

if some grandparent directory has parentheses in the name the linter incorrectly says everything is fine

I'm not sure what's up with the environment info saying "Not found" for a bunch of things, like I definitely have npm, yarn, and the vue cli. Could be that I'm using a non-default folder for yarn global things (to avoid sudoing every time).
@zrh122 zrh122 mentioned this issue Aug 15, 2019
Merged
9 tasks
haoqunjiang pushed a commit that referenced this issue Aug 21, 2019
@zrh122 @haoqunjiang
chore: add cwd option when calling globby (#4442)
51cd831 
Make globby working as expected when project path contains parentheses.

Close #4417.
haoqunjiang pushed a commit that referenced this issue Aug 21, 2019
@zrh122 @haoqunjiang
chore: add cwd option when calling globby (#4442)
90577dc 
Make globby working as expected when project path contains parentheses.

Close #4417.

(cherry picked from commit 51cd831)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

chore: add cwd option when calling globby zrh122/vue-cli
1 participant
@npfoss