Only provide baseUrl fix if baseUrl provided #1421
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jkzing
approved these changes
May 31, 2018
This was referenced May 31, 2018
|
Dang it, this broke my solution over here #869 (comment) |
|
Can you explain how to use the valet driver? I'm getting errors when I try: |
This was referenced Jun 2, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In my scenario, the page is being served by PHP and the URL to the bundle is pointed directly to the webpack dev server.
So, the website is being served at
http://my-project.testand the script is pointing tohttp://localhost:8080/app.js.By specifying
?/sockjs-nodewhen including the webpack dev server client, it is forcing the sockjs server to be on the same domain as the page. Because of https://github.com/webpack/webpack-dev-server/blob/ab4eeb007283fdf3e8950ff1f3ff8150a4812061/client-src/default/index.js#L30I need the __resourceQuery to be empty so that it gets the URL for the sockjs server from the
getCurrentScriptSourceThis PR shouldn't break for anyone already using
baseUrl.Or if there is another way to achieve what I need, please let me know!
Also required by #1390 which I am working on!