--no-fix option is ignored by vue-cli-service when using typescript. #1112
Comments
|
After some digging, appears to be related to https://github.com/substack/minimist/issues/54 and |
|
Nice catch. It's probably a unix convention. For example, in git, the --no-XXX options are used to override a previous --XXX. minimist seems to have this convention. |
|
Yeah, I'm working on a fix right now. Not a ton of experience writing tests so that is taking most of my time 😨 |
|
Awesome thanks. Don't hesitate to ask if you run into any difficulties (I'll help as best as I can but I'm not very familiar with vue cli 3 yet) |
|
in the meantime, I think @dhensche If you open a PR, I think the same bug is present in the eslint plugin (when typescript is not chosen) |
|
@BenoitAverty The if block inverting the argument doesn't do anything, but because of the minimist conventions the Could probably just get rid of that whole if block |
…pt plugin (vuejs#1112) ninja_edit -- @BenoitAverty pointed out to me that the eslint plugin was handing --no-fix in a similarly (possibly) broken manner. amending to remove the broken logic there as well
|
fixed via #1115 |
Version
3.0.0-beta.6
Reproduction link
https://github.com/BenoitAverty/vue-cli-test-tslint
Steps to reproduce
Run
npm run lint -- --no-fixornpx run vue-cli-service lint --no-fix.What is expected?
The lint errors should be reported but no file should be changed.
What is actually happening?
Errors are fixed in the file and not reported.
I would like to run linting in a precommit hook but not format the files. Currently this is not possible.
The text was updated successfully, but these errors were encountered: