Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added v-style support for objects #608

Merged
merged 1 commit into from
Dec 1, 2014
Merged

Conversation

skovhus
Copy link

@skovhus skovhus commented Nov 30, 2014

Something went wrong when squashing #607. But here it is, v-style directive now supports objects. #578

expect(spy).toHaveBeenCalledWith('-webkit-transform', scale, '')
})

it('updates object deep', function () {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just one small thing: you need to supply a done callback here and call it in nextTick.

Added v-style support for objects
@skovhus skovhus force-pushed the v-style-for-object branch from 3b18f6e to 923aee6 Compare December 1, 2014 00:03
@skovhus
Copy link
Author

skovhus commented Dec 1, 2014

Ok, that is when dealing with nextTick? It should be fixed now.

yyx990803 added a commit that referenced this pull request Dec 1, 2014
Added v-style support for objects
@yyx990803 yyx990803 merged commit 5f0cbac into vuejs:dev Dec 1, 2014
@yyx990803
Copy link
Member

Thanks! Great work :)

@skovhus
Copy link
Author

skovhus commented Dec 1, 2014

Thanks. I really like the ideas behind Vue, so I hope I can contribute more in the future. : ) I'm rather interested in this https://github.com/yyx990803/vue/issues/604

BTW, it there a dev version of the documentation? I cannot see that in https://github.com/vuejs/vuejs.org

@skovhus skovhus deleted the v-style-for-object branch December 1, 2014 00:09
@yyx990803
Copy link
Member

Greatly appreciated, I'm actually thinking about #604 just now, although I don't have a very clear vision for it yet.

There's no dev version for the doc site, I usually just quickly do a bunch of commits on master before a new release. (I've already documented about this v-style change btw)

@skovhus
Copy link
Author

skovhus commented Dec 1, 2014

👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants