Add $arguments variable in component events inline statement #1945 #1949
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| handler = (vm._scope || vm._context).$eval(attrs[i].value, true) | ||
| vm.$on(name.replace(eventRE), handler) | ||
| const scope = vm._scope || vm._context | ||
| const handler = scope.$eval(attrs[i].value, true) |
There was a problem hiding this comment.
Does it ok to use ES6 syntax here? i searched whole src codes and found there is no ES6 syntax used except modules.
There was a problem hiding this comment.
it's ok to use let and const. I am only using features that do not increase compiled file size at the moment.
rhyzx
force-pushed
the
inline-statement-variable
branch
from
4f5360b to
68423fe
Compare
yyx990803
added a commit
that referenced
this pull request
Dec 2, 2015
Add $arguments variable in component events inline statement #1945
|
👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.