Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(types): export duplicate type Sidebar #2573

Merged
merged 1 commit into from
Jul 3, 2023
Merged

fix(types): export duplicate type Sidebar #2573

merged 1 commit into from
Jul 3, 2023

Conversation

zonemeen
Copy link
Collaborator

@zonemeen zonemeen commented Jul 3, 2023

vitepress/types/default-theme.d.ts

Line 190 in 03d93da

export type Sidebar = SidebarItem[] | SidebarMulti

vitepress/types/default-theme.d.ts

Lines 225 to 236 in 03d93da

export interface Sidebar {
isOpen: Ref<boolean>
sidebar: ComputedRef<SidebarItem[]>
sidebarGroups: ComputedRef<SidebarItem[]>
hasSidebar: ComputedRef<boolean>
hasAside: ComputedRef<boolean>
leftAside: ComputedRef<boolean>
isSidebarEnabled: ComputedRef<boolean>
open: () => void
close: () => void
toggle: () => void
}

The default-theme.d.ts file exports two Sidebar types with the same name, which will then cause config.ts to report a typescript error.

@brc-dd brc-dd merged commit a99dcf9 into vuejs:main Jul 3, 2023
@zonemeen zonemeen deleted the fix/sidebar-types branch July 3, 2023 05:05
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jul 11, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@zonemeen @brc-dd