Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: rollup resolve alias #267

Merged
merged 1 commit into from
May 26, 2020
Merged

fix: rollup resolve alias #267

merged 1 commit into from
May 26, 2020

Conversation

csr632
Copy link
Member

@csr632 csr632 commented May 26, 2020 •
edited
Loading

this.resolve return a promise. This promise may resolve to null.
Without awaiting this promise, the next line resolved || { id } does not make sense.

@yyx990803 yyx990803 merged commit d71a06d into vitejs:master May 26, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@csr632 @yyx990803