fix: fix test

vitejs · Jul 20, 2020 · 74819fb · 74819fb
1 parent 9129145
commit 74819fb
Show file tree

Hide file tree

Showing 3 changed files with 20 additions and 3 deletions.
diff --git a/src/node/resolver.ts b/src/node/resolver.ts
@@ -254,7 +254,7 @@ export function createResolver(
 
       // example id: "@babel/runtime/helpers/esm/slicedToArray"
       // see the test case: /playground/TestNormalizePublicPath.vue
-      const id = publicPath.replace(moduleRE, '')
+      const id = cleanPublicPath.replace(moduleRE, '')
       const { scope, name, inPkgPath } = parseNodeModuleId(id)
       if (!inPkgPath) return publicPath
       let filePathPostFix = ''

diff --git a/src/node/server/serverPluginModuleRewrite.ts b/src/node/server/serverPluginModuleRewrite.ts
@@ -22,7 +22,13 @@ import {
   hmrDirtyFilesMap,
   latestVersionsMap
 } from './serverPluginHmr'
-import { readBody, cleanUrl, isExternalUrl, bareImportRE } from '../utils'
+import {
+  readBody,
+  cleanUrl,
+  isExternalUrl,
+  bareImportRE,
+  removeQueryTimestamp
+} from '../utils'
 import chalk from 'chalk'
 import { isCSSRequest } from '../utils/cssUtils'
 import { envPublicPath } from './serverPluginEnv'
@@ -76,7 +82,9 @@ export const moduleRewritePlugin: ServerPlugin = ({
         // before we perform hmr analysis.
         // on the other hand, static import is guaranteed to have extension
         // because they must all have gone through module rewrite.
-        const importer = resolver.normalizePublicPath(ctx.path)
+        const importer = removeQueryTimestamp(
+          resolver.normalizePublicPath(ctx.url)
+        )
         ctx.body = rewriteImports(
           root,
           content!,

diff --git a/src/node/utils/pathUtils.ts b/src/node/utils/pathUtils.ts
@@ -87,3 +87,12 @@ export function parseNodeModuleId(id: string) {
     inPkgPath
   }
 }
+
+export function removeQueryTimestamp(url: string) {
+  if (url.includes('t=')) {
+    const { path, query } = parseWithQuery(url)
+    delete query.t
+    return path + qs.stringify(query)
+  }
+  return url
+}